fix: remove parameters when resource is deleted or unlinked #12544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshbhu
reviewed
Apr 28, 2023
packages/amplify-provider-awscloudformation/src/utils/ssm-utils/delete-ssm-parameters.ts
Outdated
Show resolved
Hide resolved
akshbhu
reviewed
May 12, 2023
| @@ -480,7 +480,10 @@ export const run = async (context: $TSContext, resourceDefinition: $TSObject, re | |||
| .map(({ category, resourceName }) => context.amplify.removeDeploymentSecrets(context, category, resourceName)); | |||
|
|
|||
| await adminModelgen(context, resources); | |||
|
|
|||
| await deleteEnvironmentParametersForResources(context, context.amplify.getEnvInfo().envName, [ | |||
There was a problem hiding this comment.
Suggested change
| await deleteEnvironmentParametersForResources(context, context.amplify.getEnvInfo().envName, [ | |
| await deleteEnvironmentParametersForResources(context, [ |
envInfo we can fetch inside the function?
There was a problem hiding this comment.
That would limit the use of the function to the current environment. I updated to use stateManager to resolve the current envName.
goldbez
approved these changes
May 17, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #12544 +/- ##
===========================================
+ Coverage 0.00% 47.59% +47.59%
===========================================
Files 1296 842 -454
Lines 149743 38323 -111420
Branches 1296 7835 +6539
===========================================
+ Hits 0 18241 +18241
+ Misses 148447 18459 -129988
- Partials 1296 1623 +327
... and 1273 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akshbhu
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a step a the end of
amplify pushto remove parameters from Parameter Store for any resources that were removed during push.Issue #, if available
Fixes #12385
Description of how you validated changes
e2e test passes locally, also manually verified correct parameters are removed
Passing e2e run
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.