-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-frontend-ios): encapsulate path option values with quotes #12596
fix(amplify-frontend-ios): encapsulate path option values with quotes #12596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can we add unit tests to validate the pre & post behavior |
Hey @Amplifiyer what do you mean by pre and post behavior? |
@josefaidt Is there a chance that this broke code generation for iOS? Our team now getting this after
Reverting this commit either by a local |
…trings (aws-amplify#12596)" This reverts commit 43f73ab.
* Revert "fix(amplify-frontend-ios): pass paths to command options as strings (#12596)" (#13106) This reverts commit 43f73ab. * chore(release): Publish latest [ci skip] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] --------- Co-authored-by: aws-amplify-bot <[email protected]>
Description of changes
adds quotes to
--path
option values to prevent breaking when absolute path to amplify project contains spacesIssue #, if available
fixes #12593
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.