ci: Add codeowners for CI/CD files & folders #12695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
May 26, 2023
Co-authored-by: Kamil Sobol <[email protected]>
sobolk
previously approved these changes
May 26, 2023
kuhlmanp
previously approved these changes
May 26, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #12695 +/- ##
===========================================
+ Coverage 0.00% 47.61% +47.61%
===========================================
Files 1296 842 -454
Lines 149743 38302 -111441
Branches 1296 7833 +6537
===========================================
+ Hits 0 18239 +18239
+ Misses 148447 18441 -130006
- Partials 1296 1622 +326
... and 1275 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edwardfoyle
suggested changes
May 26, 2023
.github/CODEOWNERS
Outdated
Comment on lines
12
to
15
| /.circleci/ @awsluja @sobolk @aws-amplify/amplify-cli-admins | ||
| /scripts/ @awsluja @sobolk @aws-amplify/amplify-cli-admins | ||
| /shared-scripts.sh @awsluja @goldbez @aws-amplify/amplify-cli-admins | ||
| /codebuild_specs/ @awsluja @goldbez @aws-amplify/amplify-cli-admins |
There was a problem hiding this comment.
This should probably just be the cli-admins group. Adding individual people is One More Thing To Update when people join / leave the team
sobolk
approved these changes
May 26, 2023
edwardfoyle
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add codeowners to ensure that CI/CD files and folders are reviewed by certain members of our team.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.