fix: skip automatic form generation when datastore is not enabled #12713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/amplify-util-uibuilder/src/__tests__/cloneComponentsFromEnv.test.ts
Fixed
Show fixed
Hide fixed
awinberg-aws
force-pushed
the
fix-studio-form-generation
branch
from
472549c to
e45fcc1
Compare
awinberg-aws
force-pushed
the
fix-studio-form-generation
branch
from
75c29cb to
63ee19a
Compare
lyonsbp
previously approved these changes
Jun 1, 2023
awinberg-aws
force-pushed
the
fix-studio-form-generation
branch
from
63ee19a to
966da92
Compare
lyonsbp
approved these changes
Jun 1, 2023
letsbelopez
approved these changes
Jun 1, 2023
cwoolum
approved these changes
Jun 1, 2023
kuhlmanp
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates the uibuilder plugin to use a helper recently exposed by the API category to confirm if an application has datastore enabled. Forms that are auto-generated by uibuilder are not compatible with customer applications without datastore being enabled, so this is now being incorporated into the logic for determining if they should be generated or skipped.
Issue #, if available
Description of how you validated changes
ran
amplify-dev pullagainst a test project with datastore disabled to confirm that no auto-generated forms were created, and again with datastore enabled to confirm that the auto-generated forms are still created when opted-in.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.