Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify manual pr script #13072

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Aug 3, 2023

Description of changes

I keep running into weird corner cases with manual PR build like:

  • if submitted from branch from main repo, branch ref is passed to CB
  • if submitted from fork, current inference works well
  • if submitted from fork but also pushed to e2e branch before, somehow ref to e2e branch lands in CB

In order to simplify this, and because we have control over submitting manual build. I define an env var that I pass from manual script that is then used in CB to infer that we're in PR workflow.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner August 3, 2023 23:43
@sobolk sobolk merged commit 62bd0e9 into aws-amplify:dev Aug 4, 2023
@sobolk sobolk deleted the simplify-pr-script branch August 4, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants