Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require amplify cli admin to approve pull requests #13193

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Sep 6, 2023

Description of changes

This PR changes CODEOWNERS file to require a member of amplify-cli-admins group to approve the change.

Github evaluates branch protection rules (in a form we have them) in such a way that:

  1. It requires quorum (min number of reviewers) this can be anybody with write access to repo.
  2. It requires a code owners to approve changes under certain paths. At least one code owner approval fulfills this requirement.

Therefore combination of rules above serves effectively as two tier approval process.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner September 6, 2023 21:25
@sobolk sobolk merged commit 3f528a8 into dev Sep 6, 2023
@sobolk sobolk deleted the sobolk-patch-3 branch September 6, 2023 22:55
@sobolk sobolk mentioned this pull request Sep 11, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants