feat(amplify-util-uibuilder): amplify js backwards compatibility #13288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2023 14:31
0618
approved these changes
Oct 2, 2023
sobolk
approved these changes
Oct 2, 2023
This was referenced Oct 2, 2023
letsbelopez
deleted the
amplify-util-uibuilder/amplifyjs-backwards-compat-third-try
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update the StartCodegenJob operation to be backwards compatible for amplify js. StartCodegenJob is now passed the relevant local project dependencies for codegen to know which version of amplify js to codegen.
E.g. If the local project has a dependecy of
aws-amplify ^5.0.2, then codegen will generate v5 compatible code. If there are no dependencies yet, codegen will generate the latest code available and recommend to install the dependencies.Linux threshold increase:
The new aws-sdk version is needed to finish the feature. It also triggered the linux arm compressed threshold to be crossed. This increases the limit so it can pass.
Issue #, if available
NA
Description of how you validated changes
Unit test
Testing against a personal app
Currently running e2e tests, I'll update when they complete here.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.