feat: flow to add policies to access amplify resources from Lambda #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
kaustavghosh06
force-pushed
the
functionsPolicy
branch
from
1b26bfc to
c0e69ef
Compare
haverchuck
reviewed
May 23, 2019
| let actions = new Set(); | ||
|
|
||
| crudOptions.forEach((crudOption) => { | ||
| switch (crudOption) { |
There was a problem hiding this comment.
In the storage category we have 'create/update' option instead of both. I think it makes sense because it's illustrative of what's actually happening for the user, even though it's at the expense of slight inconsistency. Not a blocker for merging this but something that I think should be considered.
haverchuck
reviewed
May 23, 2019
|
|
||
| module.exports = { addWalkthrough, updateWalkthrough, migrate }; | ||
| crudOptions.forEach((crudOption) => { |
There was a problem hiding this comment.
In askReadWrite function, we have 'create/update' instead of 'create' and 'update'.
haverchuck
approved these changes
May 29, 2019
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.