Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default exports in the projects #2537

Merged
merged 7 commits into from
Oct 29, 2019
Merged

chore: remove default exports in the projects #2537

merged 7 commits into from
Oct 29, 2019

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Oct 9, 2019

Description of changes:

The PR prepares for enforcing the no-default-export TSLint rule, to reduce the possibility of making import errors which could happen easily and was present in the codebase.

Related links:

A PR will follow up to remove the default exports from the JS code as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from yuth October 9, 2019 11:34
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #2537 into master will increase coverage by 0.32%.
The diff coverage is 81.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2537      +/-   ##
==========================================
+ Coverage   65.67%   65.99%   +0.32%     
==========================================
  Files         199      193       -6     
  Lines        9660     9604      -56     
  Branches     1966     1947      -19     
==========================================
- Hits         6344     6338       -6     
+ Misses       3042     2990      -52     
- Partials      274      276       +2
Impacted Files Coverage Δ
packages/amplify-cli/src/context-extensions.ts 23.24% <ø> (ø) ⬆️
packages/amplify-cli/src/domain/input.ts 100% <ø> (ø) ⬆️
packages/amplify-cli/src/domain/constants.ts 100% <ø> (ø) ⬆️
...graphql-types-generator/src/typescript/language.ts 84.5% <ø> (ø) ⬆️
packages/amplify-graphql-docs-generator/src/cli.ts 0% <0%> (ø) ⬆️
.../graphql-transformer-core/src/util/amplifyUtils.ts 6.18% <10%> (ø) ⬆️
packages/amplify-cli/src/domain/context.ts 100% <100%> (ø) ⬆️
packages/amplify-cli/src/context-manager.ts 100% <100%> (ø) ⬆️
packages/graphql-auth-transformer/src/resources.ts 89.2% <100%> (ø) ⬆️
packages/amplify-cli/src/domain/plugin-platform.ts 100% <100%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a818558...a476577. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2019

This pull request introduces 2 alerts and fixes 6 when merging 50ca191 into 7de3845 - view on LGTM.com

new alerts:

  • 1 for Syntax error
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 6 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2019

This pull request introduces 1 alert and fixes 6 when merging 19fa7ff into 7de3845 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 6 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 10, 2019

This pull request introduces 1 alert and fixes 6 when merging 7e9e18a into e1de9ac - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 6 for Unused variable, import, function or class

// });
// const modelPostConnectionType = getObjectType(schemaDoc, 'ModelPostConnection');
// expect (expectOne(modelPostConnectionType, 'aws_cognito_user_pools'));
// });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just delete all this commented out code?

Copy link
Contributor

@ammarkarachi ammarkarachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some commented out files

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2019

This pull request fixes 5 alerts when merging a476577 into a818558 - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@attilah attilah merged commit 384e0b4 into aws-amplify:master Oct 29, 2019
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants