-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove default exports in the projects #2537
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2537 +/- ##
==========================================
+ Coverage 65.67% 65.99% +0.32%
==========================================
Files 199 193 -6
Lines 9660 9604 -56
Branches 1966 1947 -19
==========================================
- Hits 6344 6338 -6
+ Misses 3042 2990 -52
- Partials 274 276 +2
Continue to review full report at Codecov.
|
This pull request introduces 2 alerts and fixes 6 when merging 50ca191 into 7de3845 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 6 when merging 19fa7ff into 7de3845 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 6 when merging 7e9e18a into e1de9ac - view on LGTM.com new alerts:
fixed alerts:
|
// }); | ||
// const modelPostConnectionType = getObjectType(schemaDoc, 'ModelPostConnection'); | ||
// expect (expectOne(modelPostConnectionType, 'aws_cognito_user_pools')); | ||
// }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just delete all this commented out code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some commented out files
This pull request fixes 5 alerts when merging a476577 into a818558 - view on LGTM.com fixed alerts:
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
The PR prepares for enforcing the no-default-export TSLint rule, to reduce the possibility of making import errors which could happen easily and was present in the codebase.
Related links:
A PR will follow up to remove the default exports from the JS code as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.