-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build break, chore: typescript, lerna update #2640
Conversation
@@ -346,7 +346,7 @@ test('Test that connection type is generated for custom query when queries is se | |||
`; | |||
|
|||
const transformer = new GraphQLTransform({ | |||
transformers: [new ModelTransformer(), new KeyTransformer()], | |||
transformers: [new DynamoDBModelTransformer(), new KeyTransformer()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we change the name of the Transformer? There are many folks out here who use the transformer lib directly..so would this be a breaking change for them?
@@ -65,7 +65,7 @@ | |||
"jest": "^24.8.0", | |||
"ts-jest": "^24.0.2", | |||
"tslint": "^5.18.0", | |||
"typescript": "^3.5.3" | |||
"typescript": "^3.6.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason to upgrade the version explicitly?
Codecov Report
@@ Coverage Diff @@
## master #2640 +/- ##
=========================================
Coverage ? 64.74%
=========================================
Files ? 198
Lines ? 9820
Branches ? 1868
=========================================
Hits ? 6358
Misses ? 3190
Partials ? 272 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
Fix build break caused by a recent merge.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.