Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build break, chore: typescript, lerna update #2640

Merged
merged 3 commits into from
Oct 29, 2019
Merged

fix: build break, chore: typescript, lerna update #2640

merged 3 commits into from
Oct 29, 2019

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Oct 29, 2019

Description of changes:

Fix build break caused by a recent merge.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -346,7 +346,7 @@ test('Test that connection type is generated for custom query when queries is se
`;

const transformer = new GraphQLTransform({
transformers: [new ModelTransformer(), new KeyTransformer()],
transformers: [new DynamoDBModelTransformer(), new KeyTransformer()],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change the name of the Transformer? There are many folks out here who use the transformer lib directly..so would this be a breaking change for them?

@@ -65,7 +65,7 @@
"jest": "^24.8.0",
"ts-jest": "^24.0.2",
"tslint": "^5.18.0",
"typescript": "^3.5.3"
"typescript": "^3.6.4"
Copy link
Contributor

@kaustavghosh06 kaustavghosh06 Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to upgrade the version explicitly?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fb92a9d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2640   +/-   ##
=========================================
  Coverage          ?   64.74%           
=========================================
  Files             ?      198           
  Lines             ?     9820           
  Branches          ?     1868           
=========================================
  Hits              ?     6358           
  Misses            ?     3190           
  Partials          ?      272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb92a9d...ea12997. Read the comment docs.

Copy link
Contributor

@kaustavghosh06 kaustavghosh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kaustavghosh06 kaustavghosh06 merged commit 29fae36 into aws-amplify:master Oct 29, 2019
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants