Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass appsync specific directives to model gen #3211

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

yuth
Copy link
Contributor

@yuth yuth commented Jan 17, 2020

AppSync service has some custom directives defined in the service. These directives are defiend in
transformer, so the documents that have them pass graphql validation. Passing them to model gen
plugin from transformer to keep these directives in sync

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AppSync service has some custom directives defined in the service. These directives are defiend in
transformer, so the documents that have them pass graphql validation. Passing them to model gen
plugin from transformer to keep these directives in sync
@yuth yuth requested a review from attilah January 17, 2020 19:33
@attilah attilah merged commit c9a6ada into aws-amplify:master Jan 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #3211 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3211      +/-   ##
==========================================
+ Coverage   59.41%   59.41%   +<.01%     
==========================================
  Files         254      254              
  Lines       12583    12587       +4     
  Branches     2465     2465              
==========================================
+ Hits         7476     7479       +3     
- Misses       4794     4795       +1     
  Partials      313      313
Impacted Files Coverage Δ
...c-model-plugin/src/scalars/supported-directives.ts 100% <ø> (ø) ⬆️
...ackages/graphql-transformer-core/src/validation.ts 100% <100%> (ø) ⬆️
packages/graphql-transformer-core/src/index.ts 96.77% <75%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c855fbd...ea413f7. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants