-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-graphql-types-generator): use zen-observable-ts #4415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for submitting a PR!
@Seb6277 can this be merged into master? |
@WeMakeLive Last information I got, this should be merged into master pretty soon. @nikhname Would merging this be followed by a new release soon? I've patched our local instance, but would be nice if I can rollback our patch and update to the latest CLI to get rid of the bug. |
merged! Thanks for the contrib! |
@nikhname - as per @frederikprijck comment - what is the plan for this to be released? |
@frederikprijck @WeMakeLive these changes are available with the latest release - CLI version 4.21.2 :) |
…ify#4415) * fix(amplify-graphql-types-generator): use zen-observable-ts
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
#4419
Description of changes:
As of 3.0.13, aws-amplify is using
zen-onservable-ts
. (See: aws-amplify/amplify-js@49d295e)While upgrading our project, which was using aws-amplify 2.x.x, our TypeScript failed to compile.
As soon as I make the changes that are part of this PR, to thé API service generated by thé CLI, TypeScript compilation is succesfull again.
This PR is a first draft for further discussing. I can update the PR accordingly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.