Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-graphql-types-generator): use zen-observable-ts #4415

Merged
merged 2 commits into from
Jun 5, 2020
Merged

fix(amplify-graphql-types-generator): use zen-observable-ts #4415

merged 2 commits into from
Jun 5, 2020

Conversation

frederikprijck
Copy link
Contributor

@frederikprijck frederikprijck commented May 30, 2020

Issue #, if available:
#4419

Description of changes:
As of 3.0.13, aws-amplify is using zen-onservable-ts. (See: aws-amplify/amplify-js@49d295e)

While upgrading our project, which was using aws-amplify 2.x.x, our TypeScript failed to compile.

As soon as I make the changes that are part of this PR, to thé API service generated by thé CLI, TypeScript compilation is succesfull again.

This PR is a first draft for further discussing. I can update the PR accordingly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@nikhname nikhname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting a PR!

@WeMakeLive
Copy link

@Seb6277 can this be merged into master?

@frederikprijck
Copy link
Contributor Author

frederikprijck commented Jun 5, 2020

@WeMakeLive Last information I got, this should be merged into master pretty soon.

@nikhname Would merging this be followed by a new release soon? I've patched our local instance, but would be nice if I can rollback our patch and update to the latest CLI to get rid of the bug.

@nikhname nikhname merged commit 4e49e0c into aws-amplify:master Jun 5, 2020
@renebrandel
Copy link
Contributor

merged! Thanks for the contrib!

@frederikprijck frederikprijck deleted the patch-1 branch June 5, 2020 15:58
@WeMakeLive
Copy link

@nikhname - as per @frederikprijck comment - what is the plan for this to be released?

@nikhname
Copy link
Contributor

@frederikprijck @WeMakeLive these changes are available with the latest release - CLI version 4.21.2 :)

nikhname pushed a commit to nikhname/amplify-cli that referenced this pull request Jul 27, 2020
…ify#4415)

* fix(amplify-graphql-types-generator): use zen-observable-ts
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading AWS Amplify from 2.3.0 to 3.0.13 breaks TypeScript compilation
5 participants