Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #3910 - propagate non-model auth to nested types #4477

Merged
merged 1 commit into from
Jun 5, 2020
Merged

fix: #3910 - propagate non-model auth to nested types #4477

merged 1 commit into from
Jun 5, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Jun 5, 2020

Issue #, if available:

fix: #3910 - propagate non-model auth to nested types

Description of changes:

For non-model types then the 1st level type had nested non-model types, @auth was not propagated properly on nested types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from yuth June 5, 2020 18:53
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #4477 into master will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4477      +/-   ##
==========================================
- Coverage   62.23%   61.96%   -0.27%     
==========================================
  Files         322      331       +9     
  Lines       14390    14454      +64     
  Branches     2736     2916     +180     
==========================================
+ Hits         8956     8957       +1     
- Misses       5011     5053      +42     
- Partials      423      444      +21     
Impacted Files Coverage Δ
...aphql-auth-transformer/src/ModelAuthTransformer.ts 87.96% <100.00%> (+0.01%) ⬆️
packages/graphql-mapping-template/src/print.ts 35.71% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 88.09% <0.00%> (ø)
...ges/graphql-transformer-core/src/util/fileUtils.ts 11.76% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts 26.10% <0.00%> (ø)
...mplify-appsync-simulator/src/resolvers/function.ts 15.38% <0.00%> (ø)
...plify-appsync-simulator/src/server/subscription.ts 30.43% <0.00%> (ø)
...lify-graphql-types-generator/src/compiler/index.ts 90.32% <0.00%> (ø)
...y-graphql-types-generator/src/compiler/legacyIR.ts 96.72% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e49e0c...454be0b. Read the comment docs.

Copy link
Contributor

@yuth yuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding unit tests 💯

@attilah attilah merged commit 493e631 into aws-amplify:master Jun 5, 2020
nikhname pushed a commit to nikhname/amplify-cli that referenced this pull request Jul 27, 2020
@github-actions
Copy link

github-actions bot commented Jun 5, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL schema compilation omits needed auth directives for nested types.
2 participants