Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file existence checks, enable admin console #5922

Merged
merged 5 commits into from
Nov 21, 2020

Conversation

jhockett
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from edwardfoyle November 20, 2020 23:59
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #5922 (8bf9f53) into backendManager (3d15d63) will increase coverage by 0.10%.
The diff coverage is 52.88%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           backendManager    #5922      +/-   ##
==================================================
+ Coverage           57.98%   58.09%   +0.10%     
==================================================
  Files                 408      407       -1     
  Lines               18766    18791      +25     
  Branches             3554     3752     +198     
==================================================
+ Hits                10882    10916      +34     
+ Misses               7221     7192      -29     
- Partials              663      683      +20     
Impacted Files Coverage Δ
...ages/amplify-appsync-simulator/src/schema/index.ts 19.40% <ø> (ø)
...gory-auth/src/provider-utils/supported-services.ts 100.00% <ø> (ø)
.../amplify-category-notifications/lib/auth-helper.js 0.00% <0.00%> (ø)
packages/amplify-category-xr/lib/auth-helper.js 20.00% <0.00%> (-5.00%) ⬇️
packages/amplify-cli-core/src/index.ts 100.00% <ø> (ø)
...mplify-frontend-ios/lib/frontend-config-creator.js 16.23% <ø> (ø)
...ejs-function-runtime-provider/src/utils/execute.ts 73.21% <0.00%> (-1.34%) ⬇️
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/utils/config-override.ts 0.00% <ø> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949680d...8bf9f53. Read the comment docs.

stateManager,
$TSContext,
} from 'amplify-cli-core';
const { doAdminCredentialsExist } = require('amplify-provider-awscloudformation');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason this isn't an import ... from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, using import was breaking things.

packages/amplify-cli/src/commands/console.ts Outdated Show resolved Hide resolved
packages/amplify-cli/src/commands/console.ts Outdated Show resolved Hide resolved
@jhockett jhockett merged commit 80097ab into aws-amplify:backendManager Nov 21, 2020
@jhockett jhockett deleted the ampAdmin branch November 21, 2020 02:40
edwardfoyle pushed a commit to edwardfoyle/amplify-cli that referenced this pull request Nov 21, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants