Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gql compiler fix for user defined mutation #6059

Merged
merged 6 commits into from
Mar 5, 2021

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Dec 4, 2020

*Issue #5715

Description of changes:

  • Added a check @key to skip updating Input types when user defined input in mutation

  • Added a FF : skipOverrideMutationInputTypes to skip changes in existing projects

  • added unit tests for the same

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu requested review from yuth and SwaySway December 4, 2020 03:46
@akshbhu akshbhu linked an issue Dec 4, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #6059 (768f4c3) into master (44ea91a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6059      +/-   ##
==========================================
+ Coverage   56.45%   56.47%   +0.01%     
==========================================
  Files         430      430              
  Lines       21138    21147       +9     
  Branches     4237     4241       +4     
==========================================
+ Hits        11933    11942       +9     
  Misses       8392     8392              
  Partials      813      813              
Impacted Files Coverage Δ
...amplify-cli-core/src/feature-flags/featureFlags.ts 83.10% <ø> (ø)
...ages/graphql-key-transformer/src/KeyTransformer.ts 93.08% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ea91a...768f4c3. Read the comment docs.

@akshbhu akshbhu added the graphql-transformer-v1 Issue related to GraphQL Transformer v1 label Dec 7, 2020
@akshbhu
Copy link
Contributor Author

akshbhu commented Jan 28, 2021

Raised a pR for docs repo for FF : aws-amplify/docs#2897

@attilah attilah merged commit 063d84f into aws-amplify:master Mar 5, 2021
akshbhu added a commit to akshbhu/amplify-cli that referenced this pull request Mar 5, 2021
@akshbhu akshbhu mentioned this pull request Mar 5, 2021
akshbhu added a commit to akshbhu/amplify-cli that referenced this pull request Mar 5, 2021
attilah pushed a commit that referenced this pull request Mar 5, 2021
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
graphql-transformer-v1 Issue related to GraphQL Transformer v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema compiler overwrites self-defined resolver input
4 participants