Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle no mock args #6659

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Conversation

edwardfoyle
Copy link
Contributor

Issue #, if available:
#6653
Description of changes:
Handle case where no options are specified to mock

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner February 17, 2021 19:35
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #6659 (06df18a) into master (38dab98) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6659      +/-   ##
==========================================
+ Coverage   56.71%   56.76%   +0.04%     
==========================================
  Files         484      484              
  Lines       22006    22006              
  Branches     4395     4397       +2     
==========================================
+ Hits        12481    12492      +11     
+ Misses       8648     8638      -10     
+ Partials      877      876       -1     
Impacted Files Coverage Δ
...ges/amplify-codegen/src/utils/getGraphQLDocPath.js 100.00% <100.00%> (ø)
packages/amplify-codegen/src/walkthrough/add.js 87.09% <100.00%> (+0.21%) ⬆️
...kages/amplify-codegen/src/walkthrough/configure.js 88.23% <100.00%> (+0.35%) ⬆️
packages/amplify-util-mock/src/func/index.ts 94.11% <100.00%> (+4.41%) ⬆️
...ges/amplify-codegen/src/utils/getIncludePattern.js 55.55% <0.00%> (+44.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82b069...06df18a. Read the comment docs.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwardfoyle edwardfoyle merged commit 6b97ffa into aws-amplify:master Feb 17, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants