Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check for undefined attributes during push #6687

Merged
merged 1 commit into from
Feb 26, 2021
+1 −1
Merged

fix: add check for undefined attributes during push #6687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/amplify-provider-awscloudformation/src/push-resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ async function formNestedStack(

if (dependsOn) {
for (let i = 0; i < dependsOn.length; i += 1) {
for (let j = 0; j < dependsOn[i].attributes.length; j += 1) {
for (let j = 0; j < dependsOn[i]?.attributes?.length || 0; j += 1) {
// If the depends on resource is an imported resource we cannot form GetAtt type reference
// since there is no such thing. We have to read the output.{AttributeName} from the meta
// and inject the value itself into the parameters block
Expand Down