Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-provider-awscloudformation): reverse asc events #6803

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Mar 5, 2021

Fixes #6578

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@watilde watilde requested a review from a team as a code owner March 5, 2021 08:08
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #6803 (0e5ed2c) into master (e67dcdf) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6803      +/-   ##
==========================================
+ Coverage   56.50%   56.55%   +0.05%     
==========================================
  Files         430      431       +1     
  Lines       21140    21174      +34     
  Branches     4237     4240       +3     
==========================================
+ Hits        11946    11976      +30     
- Misses       8381     8385       +4     
  Partials      813      813              
Impacted Files Coverage Δ
...src/iterative-deployment/stack-progress-printer.ts 88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67dcdf...0e5ed2c. Read the comment docs.

attilah
attilah previously requested changes Mar 5, 2021
Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I added a comment on the implementation, please update it and the it is good to be merged.

@watilde watilde force-pushed the fixes-print-order branch from 2f3a503 to 0e5ed2c Compare March 6, 2021 04:02
@watilde watilde changed the title fix(amplify-provider-awscloudformation): print events order by timestamp fix(amplify-provider-awscloudformation): reverse asc events Mar 6, 2021
@jhockett jhockett dismissed attilah’s stale review March 16, 2021 01:52

Feedback has been addressed

@ammarkarachi ammarkarachi merged commit ae02803 into aws-amplify:master Mar 19, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudformation messages are printed in the wrong order
4 participants