fix: validate references on belongsTo when cpk is disabled #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
changed the title
palpatim
reviewed
Apr 25, 2024
| const isUsingReferences = references.length > 0; | ||
| if (isUsingReferences) { | ||
| // ensure there is a matching hasOne/hasMany field with references | ||
| getConnectedFieldV2(field, model, otherSide, connectionDirective.name) |
phani-srikar
previously approved these changes
Apr 25, 2024
dpilch
force-pushed
the
associated-field-native
branch
from
50cd346 to
14ee319
Compare
dpilch
changed the base branch from
associated-field-native
to
connected-field-refactor
dpilch
force-pushed
the
cpk-references
branch
3 times, most recently
from
0bcf9c8 to
6ecb5bf
Compare
dpilch
changed the base branch from
connected-field-refactor
to
associated-field-native
3 tasks
palpatim
previously approved these changes
Apr 26, 2024
palpatim
dismissed stale reviews from phani-srikar and themself
The base branch was changed.
atierian
previously approved these changes
Apr 26, 2024
palpatim
approved these changes
Apr 26, 2024
atierian
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
hasOne/hasManywhen processing a belongsTo when cpk is disabledgetConnectedFieldV2and put ingetConnectedFieldForReferencesCodegen Paramaters Changed or Added
N/A
Issue #, if available
Discovered by testing in with native.
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.