feat(datastore): Migrate to Amplify Swift V2 #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikaHsn
reviewed
Jun 3, 2024
Comment on lines
101
to
108
| // TODO: Migrate to Async Swift v2 | ||
| // This enables custom selection set behavior within Amplify-Swift v1. | ||
| // Which allows models to be decoded when created on Android and received to iOS | ||
| extension FlutterModelSchema: SubscriptionSelectionSetBehavior { | ||
| public var includePrimaryKeysOnly: Bool { | ||
| return true | ||
| } | ||
| } | ||
| // Which allows models to be decoded when created on Android and received to iOS | ||
| //extension FlutterModelSchema: SubscriptionSelectionSetBehavior { | ||
| // public var includePrimaryKeysOnly: Bool { | ||
| // return true | ||
| // } | ||
| //} |
There was a problem hiding this comment.
You may want to remove the commented code here or to uncomment it?
tyllark
previously approved these changes
Jun 3, 2024
tyllark
approved these changes
Jun 4, 2024
Jordan-Nelson
approved these changes
Jun 4, 2024
Equartey
added a commit
that referenced
this pull request
Jun 4, 2024
Equartey
added a commit
that referenced
this pull request
Jun 4, 2024
Equartey
added a commit
that referenced
this pull request
Jun 4, 2024
Equartey
added a commit
that referenced
this pull request
Jun 7, 2024
Equartey
added a commit
that referenced
this pull request
Jun 10, 2024
Equartey
added a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Support for Amplify Swift V1 via CocoaPods was depreciated May 31, 2024. This work migrates our implementation to consume the newer Amplify Swift V2 SPM based project. It does this by the following:
This means we no longer consume Amplify Swift via CocoaPods. Allowing us to consume the most up to date Amplify Swift features and fixes. Also noting remote sync GraphQL requests are now routed back to our Dart based API category via the Flutter method channel. This further reduces the dependency on Amplify Swift Plugins.
Note: At a latter date when the Flutter platform supports SPM we can natively consume the SPM package instead of copying and shipping Amplify Swift source files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.