feat: support server-side auth flows with Cognito managed login #14168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13788) * feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner * chore: resolve comments * chore(adapter-nextjs): adapt the latest impl. changes
…er (#13801) * feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner * feat(adapter-nextjs): add createAuthRouteHandlers to createServerRunner * chore(adapter-nextjs): resolve comments * chore(adapter-nextjs): remove unnecessary check
…ed UI (#13827) * chore(auth): export necessary utilities and types to support server-side auth * chore(aws-amplify): export necessary utilities to support server-side auth * feat(adapter-nextjs): server-side auth api route integrating cognito hosted ui * chore(adapter-nextjs): resolve comments * refactor(adapter-nextjs): remove redundant username fallback
…sign-in and sign-up (#13839) * feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up * chore(adapter-nextjs): rename hasUserSignedIn to hasActiveUserSession
…oth App and Pages routers (#13840)
…13841) * feat(adapter-nextjs): allow cookie secure: false with non-SSL domain * fix(adapter-nextjs): wrong naming and impl. of isSSLOrigin * chore(adapter-nextjs): resolve comment
…ver to avoid clock drift (#14103)
refactor(adapter-nextjs): remove redundant clockDrift cookie⤵️ Reasons: 1. token exachange is happening on a server - and production server rarely has wrong system time 2. when setting token cookies from server, it uses Max-Age header which is relative to the client system time. Clock drift became irrelevant 3. surely we can argue sever system time can go wrong too, however, a Next.js app API route can be executed on different servers (load balancing), there is no source of truth to generate a clock drift value
#14116) * feat(adapter-nextjs): surface redirect error and sign-in timeout error * feat(adapter-nextjs): expose both error and errorDescription * chore(adapter-nextjs): remove unnecessary undefined fallback
* fix(core): generateRandomString uses Math.random() * chore(core): use better test to test actual logic
HuiSF
requested review from
sktimalsina,
cshfang,
pranavosu and
a team
as code owners
HuiSF
changed the title
|
Please ensure that this PR:
A repository administrator is required to review this change. |
cshfang
previously approved these changes
Jan 27, 2025
Comment on lines
+34
to
+39
| "./api/internals": { | ||
| "types": "./dist/esm/api/internals.d.ts", | ||
| "import": "./dist/esm/api/internals.mjs", | ||
| "require": "./dist/cjs/api/internals.js", | ||
| "react-native": "./src/api/internals.ts" | ||
| }, |
There was a problem hiding this comment.
Why are we exposing the /apii/internals export subpath from aws-amplify rather than @aws-amplify/core?
There was a problem hiding this comment.
You mean importing things from @aws-amplify/core? If so, this is due to @aws-amplify/adapter-nextjs has only aws-amplify as a peer dependency, and it cannot add @aws-amplify/core as a dependency.
There was a problem hiding this comment.
Not sure that is entirely correct. Let's discuss offline
cshfang
previously approved these changes
Feb 3, 2025
jjarvisp
approved these changes
Feb 7, 2025
cshfang
approved these changes
Feb 10, 2025
ashika112
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Merging the server-side auth feature branch.
Feature code change details see commits messages of this PR.
Squash and merge is required!
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.