feat(aws-amplify-react-native): Add S3Text

[cedricgrothues]

Issue #, if available: N/A

Description of changes: This PR is part of the React Native Storage Refactor and adds an S3Text component to aws-amplify-react-native.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Merging #6594 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6594   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files         208      208           
  Lines       12928    12928           
  Branches     2526     2526           
=======================================
  Hits         9477     9477           
  Misses       3260     3260           
  Partials      191      191           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d5e17...34beaf0. Read the comment docs.

[ashika01]

@cedricgrothues Looks like this is ready for review, could you change the status then? also could you update the screenshot with mobile screenshot?! like how it looks on android vs iOS (like how we did for the docs)

[amhinson]

Looking great so far! I've made a couple of specific comments, but at a general level it'd be very helpful to also include a video/gif of this in action for more confirmation. I'm particularly interested in seeing the body prop being used for Storage.put as well as just the general content loading.

Also, since this is would be the first implementation for aws-amplify-react-native using hooks, would you be able to verify any potential limitations of using this component or the library as a whole in previous version of React Native that don't support hooks (< 0.59)?

[lgtm-com]

This pull request introduces 1 alert when merging 8c1cd80 into 128527c - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[cedricgrothues]

I'm particularly interested in seeing the body prop being used for Storage.put as well as just the general content loading.

@amhinson – As a placeholder, while loading the content from S3?

[amhinson]

@amhinson – As a placeholder, while loading the content from S3?

Just curious in general to see the upload working as well as how the component behaves while the content is loading.

[cedricgrothues]

Also, since this is would be the first implementation for aws-amplify-react-native using hooks, would you be able to verify any potential limitations of using this component or the library as a whole in previous version of React Native that don't support hooks (< 0.59)?

@amhinson @ashika01 – As far as I can tell, react-native < 0.59 does not support any iOS <= 13, so I'm not too sure how many developers are still using it.

Last version that doesn't support hooks: 0.58.6 (published Feb 28, 2019)
The issue tracking support for iOS 13: facebook/react-native#25181 (published Jun 6, 2019)

[amhinson]

@cedricgrothues I have come across some apps that are still using 0.58 (albeit a small percentage). In general, we're just looking to know what someone using < 0.59 might encounter, i.e.:

• Will they see an error using withAuthenticator even if they don't use S3Text?
• Will an error only show if using S3Text directly?

[cedricgrothues]

@amhinson – I just tested the S3Text component on Android with react-native < 0.59, and it turns out that importing the library, even without importing S3Text, causes an undefined is not a function error.

[sammartinez]

@calebpollman and @Ashish-Nanda, are we still looking to add this? If not, I would like to close this pull request.

[calebpollman]

@sammartinez Will take a look, thanks for bringing to my attention!

[calebpollman]

@Ashish-Nanda Took a quick look at this and think code wise it is fine for the most part but wanted to confirm whether we are looking to add this to aws-amplify-react-native? I don't have much context but I am assuming it was meant to function as the React Native implementation for the React AmplifyS3Text component?

[abdallahshaban557]

Hi @cedricgrothues - these React Native components for Storage are on their path to deprecation. I am closing this PR. Apologies for not getting to this sooner!