Skip to content

Commit

Permalink
chore(auth): add more auto sign in and sign up state machine/e2e unit…
Browse files Browse the repository at this point in the history 
… tests (#161)

* chore(auth): add more auto sign in and sign up state machine/e2e unit tests

* Address review comments
  • Loading branch information
@thisisabhash
thisisabhash authored Nov 5, 2024
1 parent 56b31e0 commit 3df1ef0
Show file tree
Hide file tree
Showing 11 changed files with 962 additions and 14 deletions.
10 changes: 8 additions & 2 deletions AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Task/AWSAuthSignUpTask.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,16 @@ class AWSAuthSignUpTask: AuthSignUpTask, DefaultLogger {
let stateSequences = await authStateMachine.listen()
log.verbose("Validating current state")
for await state in stateSequences {
guard case .configured(_ , _, _) = state else {
guard case .configured(_ , _, let signUpState) = state else {
continue
}

switch signUpState {
case .notStarted, .awaitingUserConfirmation, .error, .signedUp:
return
default:
continue
}
return
}
}
}
276 changes: 276 additions & 0 deletions ...nitoAuthPluginUnitTests/TaskTests/ClientBehaviorTests/SignIn/AWSAuthAutoSignInTests.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,282 @@ class AutoSignInTests: BasePluginTest {
}
}

/// Test auto sign in failure
///
/// - Given: Given an auth plugin with mocked service and in `.notStarted` sign up state
///
/// - When:
/// - I invoke autoSignIn
/// - Then:
/// - I should get a failure with error response
///
func testAutoSignInFailureFromNotStartedState() async {
let mockIdentityProvider = MockIdentityProvider(
mockSignUpResponse: { _ in
return .init(
codeDeliveryDetails: .init(
attributeName: "some attribute",
deliveryMedium: .email,
destination: ""
),
userConfirmed: false,
userSub: "userSub"
)
},
mockInitiateAuthResponse: { input in
return InitiateAuthOutput(
authenticationResult: .init(
accessToken: Defaults.validAccessToken,
expiresIn: 300,
idToken: "idToken",
newDeviceMetadata: nil,
refreshToken: "refreshToken",
tokenType: ""))
},
mockConfirmSignUpResponse: { request in
XCTAssertNil(request.clientMetadata)
XCTAssertNil(request.forceAliasCreation)
return .init(session: "session")
}
)

let initialStateNotStarted = AuthState.configured(
.signedOut(.init(lastKnownUserName: nil)),
.configured,
.notStarted)


let authPluginNotStarted = configureCustomPluginWith(userPool: { mockIdentityProvider },
initialState: initialStateNotStarted)
do {
let _ = try await authPluginNotStarted.autoSignIn()
XCTFail("Auto sign in should not be successful from .notStarted state")
} catch {
XCTAssertNotNil(error)
}
}

/// Test auto sign in failure
///
/// - Given: Given an auth plugin with mocked service and in `.initiatingSignUp` sign up state
///
/// - When:
/// - I invoke autoSignIn
/// - Then:
/// - I should get a failure with error response
///
func testAutoSignInFailureFromInitiatingSignUpState() async {
let mockIdentityProvider = MockIdentityProvider(
mockSignUpResponse: { _ in
return .init(
codeDeliveryDetails: .init(
attributeName: "some attribute",
deliveryMedium: .email,
destination: ""
),
userConfirmed: false,
userSub: "userSub"
)
},
mockInitiateAuthResponse: { input in
return InitiateAuthOutput(
authenticationResult: .init(
accessToken: Defaults.validAccessToken,
expiresIn: 300,
idToken: "idToken",
newDeviceMetadata: nil,
refreshToken: "refreshToken",
tokenType: ""))
},
mockConfirmSignUpResponse: { request in
XCTAssertNil(request.clientMetadata)
XCTAssertNil(request.forceAliasCreation)
return .init(session: "session")
}
)

let initialStateInitiatingSignUp = AuthState.configured(
.signedOut(.init(lastKnownUserName: nil)),
.configured,
.initiatingSignUp(.init(username: "user")))

let authPluginInitiatingSignUp = configureCustomPluginWith(userPool: { mockIdentityProvider },
initialState: initialStateInitiatingSignUp)

do {
let _ = try await authPluginInitiatingSignUp.autoSignIn()
XCTFail("Auto sign in should not be successful from .initiatingSignUp state")
} catch {
XCTAssertNotNil(error)
}
}

/// Test auto sign in failure
///
/// - Given: Given an auth plugin with mocked service and in `.awaitingUserConfirmation` sign up state
///
/// - When:
/// - I invoke autoSignIn
/// - Then:
/// - I should get a failure with error response
///
func testAutoSignInFailureFromAwaitingUserConfirmationState() async {
let mockIdentityProvider = MockIdentityProvider(
mockSignUpResponse: { _ in
return .init(
codeDeliveryDetails: .init(
attributeName: "some attribute",
deliveryMedium: .email,
destination: ""
),
userConfirmed: false,
userSub: "userSub"
)
},
mockInitiateAuthResponse: { input in
return InitiateAuthOutput(
authenticationResult: .init(
accessToken: Defaults.validAccessToken,
expiresIn: 300,
idToken: "idToken",
newDeviceMetadata: nil,
refreshToken: "refreshToken",
tokenType: ""))
},
mockConfirmSignUpResponse: { request in
XCTAssertNil(request.clientMetadata)
XCTAssertNil(request.forceAliasCreation)
return .init(session: "session")
}
)

let initialStateAwaitingUserConfirmation = AuthState.configured(
.signedOut(.init(lastKnownUserName: nil)),
.configured,
.awaitingUserConfirmation(.init(username: "user"), .init(.completeAutoSignIn("session"))))

let authPluginAwaitingUserConfirmation = configureCustomPluginWith(userPool: { mockIdentityProvider },
initialState: initialStateAwaitingUserConfirmation)

do {
let _ = try await authPluginAwaitingUserConfirmation.autoSignIn()
XCTFail("Auto sign in should not be successful from .awaitingUserConfirmation state")
} catch {
XCTAssertNotNil(error)
}
}

/// Test auto sign in failure
///
/// - Given: Given an auth plugin with mocked service and in `.confirmingSignUp` sign up state
///
/// - When:
/// - I invoke autoSignIn
/// - Then:
/// - I should get a failure with error response
///
func testAutoSignInFailureFromConfirmingSignUpState() async {
let mockIdentityProvider = MockIdentityProvider(
mockSignUpResponse: { _ in
return .init(
codeDeliveryDetails: .init(
attributeName: "some attribute",
deliveryMedium: .email,
destination: ""
),
userConfirmed: false,
userSub: "userSub"
)
},
mockInitiateAuthResponse: { input in
return InitiateAuthOutput(
authenticationResult: .init(
accessToken: Defaults.validAccessToken,
expiresIn: 300,
idToken: "idToken",
newDeviceMetadata: nil,
refreshToken: "refreshToken",
tokenType: ""))
},
mockConfirmSignUpResponse: { request in
XCTAssertNil(request.clientMetadata)
XCTAssertNil(request.forceAliasCreation)
return .init(session: "session")
}
)

let initialStateConfirmingSignUp = AuthState.configured(
.signedOut(.init(lastKnownUserName: nil)),
.configured,
.confirmingSignUp(.init(username: "user")))

let authPluginConfirmingSignUp = configureCustomPluginWith(userPool: { mockIdentityProvider },
initialState: initialStateConfirmingSignUp)

do {
let _ = try await authPluginConfirmingSignUp.autoSignIn()
XCTFail("Auto sign in should not be successful from .confirmingSignUp state")
} catch {
XCTAssertNotNil(error)
}
}

/// Test auto sign in failure
///
/// - Given: Given an auth plugin with mocked service and in `.error` sign up state
///
/// - When:
/// - I invoke autoSignIn
/// - Then:
/// - I should get a failure with error response
///
func testAutoSignInFailureFromErrorState() async {
let mockIdentityProvider = MockIdentityProvider(
mockSignUpResponse: { _ in
return .init(
codeDeliveryDetails: .init(
attributeName: "some attribute",
deliveryMedium: .email,
destination: ""
),
userConfirmed: false,
userSub: "userSub"
)
},
mockInitiateAuthResponse: { input in
return InitiateAuthOutput(
authenticationResult: .init(
accessToken: Defaults.validAccessToken,
expiresIn: 300,
idToken: "idToken",
newDeviceMetadata: nil,
refreshToken: "refreshToken",
tokenType: ""))
},
mockConfirmSignUpResponse: { request in
XCTAssertNil(request.clientMetadata)
XCTAssertNil(request.forceAliasCreation)
return .init(session: "session")
}
)

let initialStateError = AuthState.configured(
.signedOut(.init(lastKnownUserName: nil)),
.configured,
.error(.service(error: AuthError.service("Unknown error", "Unknown error"))))

let authPluginError = configureCustomPluginWith(userPool: { mockIdentityProvider },
initialState: initialStateError)

do {
let _ = try await authPluginError.autoSignIn()
XCTFail("Auto sign in should not be successful from .error state")
} catch {
XCTAssertNotNil(error)
}
}


// MARK: - Service error for initiateAuth

/// Test a autoSignIn with an `InternalErrorException` from service
Expand Down
Loading

0 comments on commit 3df1ef0

Please sign in to comment.