Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SQL Result Set to Model conversion #157

Closed
drochetti opened this issue Nov 25, 2019 · 1 comment
Closed

Improve SQL Result Set to Model conversion #157

drochetti opened this issue Nov 25, 2019 · 1 comment
Labels
datastore Issues related to the DataStore category feature-request Request a new feature

Comments

@drochetti
Copy link
Contributor

this gave a huge performance boost to SQL result set -> model conversion. I believe this is still need more testing and most likely there are more performance improvements to be made, but I would say that so far so good. I query of 1300 rows, including a joint table with 50 rows took less than 80ms to de-serialize.

That said, I'm not 100% happy with this logic, readability and caching strategy

Originally posted by @drochetti in #153
@drochetti drochetti mentioned this issue Nov 25, 2019
Merged
@palpatim palpatim added datastore Issues related to the DataStore category enhancement labels Jan 13, 2020
@drochetti
Copy link
Contributor Author

Fixed by #520

@lawmicha lawmicha added feature-request Request a new feature and removed enhancement labels Jul 8, 2021
harsh62 added a commit that referenced this issue Nov 22, 2024
@thisisabhash @harsh62
feat(auth): add support for passwordless sign up and auto sign in (#160)
364b966 
* add autoSignIn() category API definitions (#152)

* add autoSignIn() category API definitions

* add sign up step for auto sign in

* add state machine changes for autoSignIn() and signUp() (#154)

* add autoSignIn() category API definitions

* add sign up step for auto sign in

* add state machine changes

* add events and update resolvers

* update sign up events and resolvers

* add updates to resolver for auto sign in

* update confirm sign up flow and debug code

* Address review comments

---------

Co-authored-by: Harsh <[email protected]>

* update auto sign state machine events and resolver (#157)

* update auto sign state machine events and resolver

* Address review comments

* update sign up and auto sign in unit tests (#159)

* update sign up and auto sign in unit tests

* add auto sign in tests and refactor existing tests

* Add more service error tests

* Address review changes

---------

Co-authored-by: Harsh <[email protected]>
harsh62 added a commit that referenced this issue Nov 25, 2024
@harsh62 @sebaland @thisisabhash
Merge pull request #3920 from aws-amplify/passwordless
edd2aa7 
* feat(auth): adding support for email mfa (#3892)

* feat(auth): adding support for email mfa

* fix swift lint warning

* worked on a review comment

* adding integration tests wave 1

* integration tests wave 2

* integration tests wave 3

* Add test setup instructions wave 4

* Add edge case

* update readme to include graphQL details

* chore: initial commit to add sdk with passwordless models

* chore: model update

* feat(Auth): Adding WebAuthn APIs (#153)

* feat(Auth): Adding List WebAuthn API

* feat(Auth): Adding associate and delete WebAuthn credentials APIs

* Addding missing transports array in the credentials payload

* Adding friendlyName to AuthWebAuthnCredential

* Adding excludedCredentials to avoid multiple PassKeys for the same device

* Adding pagination support in the list API

* Renaming CredentialPayload to CredentialRegistrationPayload

* Addressing PR comments

* feat(auth): add passwordless sign with otp (#151)

* feat(auth): add passwordless OTP implementation

* add fallback password and password srp flows

* add web auth n states

* modifying states

* feat(Auth): Adding WebAuthn support to signIn and confirmSignIn APIs (#155)

* feat(auth): add passwordless OTP implementation

* add fallback password and password srp flows

* add web auth n states

* modifying states

* feat(Auth): Implementing signIn with WebAuthn

* Adding support for a presentation anchor in sign in and confirm sign in options

* Fixing errors

* Addressing PR comments

* fix build error

---------

Co-authored-by: Harshdeep Singh <[email protected]>

* fix: Fixing build issue when iOS 18/macOS 15 are not installed

* feat(WebAuthn): Adding support for retrying a confirmSignIn with WebAuthn request, if the first one fails (#158)

* feat(auth): add support for passwordless sign up and auto sign in (#160)

* add autoSignIn() category API definitions (#152)

* add autoSignIn() category API definitions

* add sign up step for auto sign in

* add state machine changes for autoSignIn() and signUp() (#154)

* add autoSignIn() category API definitions

* add sign up step for auto sign in

* add state machine changes

* add events and update resolvers

* update sign up events and resolvers

* add updates to resolver for auto sign in

* update confirm sign up flow and debug code

* Address review comments

---------

Co-authored-by: Harsh <[email protected]>

* update auto sign state machine events and resolver (#157)

* update auto sign state machine events and resolver

* Address review comments

* update sign up and auto sign in unit tests (#159)

* update sign up and auto sign in unit tests

* add auto sign in tests and refactor existing tests

* Add more service error tests

* Address review changes

---------

Co-authored-by: Harsh <[email protected]>

* chore: fix building of unit tests after sign up rebase

* feat(auth): adding passwordless sign in preferred flows (#162)

* feat(auth): add passwordless preferred flow

* adding confirm device and device srp flows to user auth

* update message

* worked on review comments

* update

* chore(auth): add more auto sign in and sign up state machine/e2e unit tests (#161)

* chore(auth): add more auto sign in and sign up state machine/e2e unit tests

* Address review comments

* chore: updated SDK and models

* chore: update integration test host app

* fix: Fixing build errors in watchOS/tvOS due to missing prechecks.

* feat(auth): adding an initial passwordless integration test with resources defined (#163)

* chore: update no-auth API's in the resolver

* chore: Updating to the renamed WebAuthn APIs (#164)

* chore: Updating to the renamed WebAuthn APIs

* Fixing unit tests

* chore: Adding unit tests for the WebAuthn APIs Tasks (#165)

* test: Adding AssociateWebAuthn unit tests

* test: Adding ListWebAuthnCredentials unit tests

* test: Adding DeleteWebAuthnCredential unit tests

* chore: simplifying how webauthn errors are handled

* adressing PR comments

* chore(auth): add integration tests for passwordless signup and auto sign in (#166)

* chore(auth): add integration tests for passwordless signup and auto sign in

* remove unused code

* refactor code

* chore: add integration tests for sign in flows (#168)

* chore: add integration tests for sign in flows

* Update AuthSignInWithPasswordUsingUserAuthTests.swift

* Add more integration tests

* update

* chore: update sdk to use the latest models

* test: Adding integration tests for WebAuthn APIs (#169)

* test: Adding integration tests for WebAuthn APIs

* chore: Adding webauthn integration workflow

* Refactoring the code to remove unnecesary waits and make it more easy to read

* fix: Fixing service errors being reported as .unknown when sign in fails (#170)

* fix: Fixing service errors being reported as .unknown when sign in fails. Also adding proper WebAuthn cases to the AWSCognitoAuthError enum.

* addressing PR comment

* fix(auth): fix resolvers and tasks for auto sign in when state machine is in signing in state (#172)

* fix(auth): fix resolvers and tasks for auto sign in when state machine is in signin in state

* fix indentation

* feat: Adding visionOS support to the WebAuthn APIs (#171)

* chore: using the latest version aws sdk

* chore: update changes needed for the sdk updated

* chore: fix swiftlint errors (#3921)

* chore: running passwordless integration tests on GEN2 backend

* chore: update test target for watchOS

* chore: fix OTP integration tests

* chore: update more integration tests

---------

Co-authored-by: Sebastian Villena <[email protected]>
Co-authored-by: Abhash Kumar Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datastore Issues related to the DataStore category feature-request Request a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@palpatim @drochetti @lawmicha