-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Auth): Adding forceAliasCreation option during confirmSignUp #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpanshu
approved these changes
Nov 27, 2023
sebaland
previously approved these changes
Feb 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3382 +/- ##
==========================================
+ Coverage 68.10% 68.18% +0.07%
==========================================
Files 1080 1080
Lines 36343 36347 +4
==========================================
+ Hits 24753 24782 +29
+ Misses 11590 11565 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 0f804d8.
sebaland
approved these changes
Mar 18, 2024
5d
added a commit
that referenced
this pull request
Mar 19, 2024
…RLSession (#3527) * feat(datastore): replace appSync realtime client with URLSession * Add timeout for appsync realtime request * adding unit test cases * move websocket components to core * added more interfaces for unit test * add unit test cases for websocket client * fix broken integration test cases * change appsync client state to a subject * Add resettable for appsync and websocket clients * add integration test cases for appsync client * Add subscription actor * fix subscription life cycle issue * add integration test cases for datastore with large number of models * add integration test case for max subscription reached * fix auth error handling for AppSyncRealTimeRequest errors * add doc comments for WebSocketClient and AppSyncRealTimeClient * add integration test case for retry on maxSubscriptionReached * move sendRequest to appSyncRealTimeClient * Add more doc comments * bind tasks cancellables to connection life cycle * update websocket spi name * resolve comments * fix(Logging): Updating the required reason API usage (#3570) * chore: release 2.27.3 [skip ci] * chore: finalize release 2.27.3 [skip ci] * feat(Auth): Adding forceAliasCreation option during confirmSignUp (#3382) * feat(Auth): Adding forceAliasCreation option during confirmSignUp * update pinpoint unit tests * Revert "update pinpoint unit tests" This reverts commit 0f804d8. * rename CognitoAuth to AuthToken --------- Co-authored-by: Harsh <[email protected]> Co-authored-by: Abhash Kumar Singh <[email protected]> Co-authored-by: aws-amplify-ops <[email protected]>
lawmicha
pushed a commit
that referenced
this pull request
Mar 20, 2024
) (#3577) * feat(Auth): Adding forceAliasCreation option during confirmSignUp * update pinpoint unit tests * Revert "update pinpoint unit tests" This reverts commit 0f804d8. Co-authored-by: Harsh <[email protected]>
5d
added a commit
that referenced
this pull request
Mar 22, 2024
…RLSession (#3575) * feat(API): implement AppSyncRealTimeClient and WebSocketClient with URLSession (#3527) * feat(datastore): replace appSync realtime client with URLSession * Add timeout for appsync realtime request * adding unit test cases * move websocket components to core * added more interfaces for unit test * add unit test cases for websocket client * fix broken integration test cases * change appsync client state to a subject * Add resettable for appsync and websocket clients * add integration test cases for appsync client * Add subscription actor * fix subscription life cycle issue * add integration test cases for datastore with large number of models * add integration test case for max subscription reached * fix auth error handling for AppSyncRealTimeRequest errors * add doc comments for WebSocketClient and AppSyncRealTimeClient * add integration test case for retry on maxSubscriptionReached * move sendRequest to appSyncRealTimeClient * Add more doc comments * bind tasks cancellables to connection life cycle * update websocket spi name * resolve comments * fix(Logging): Updating the required reason API usage (#3570) * chore: release 2.27.3 [skip ci] * chore: finalize release 2.27.3 [skip ci] * feat(Auth): Adding forceAliasCreation option during confirmSignUp (#3382) * feat(Auth): Adding forceAliasCreation option during confirmSignUp * update pinpoint unit tests * Revert "update pinpoint unit tests" This reverts commit 0f804d8. * rename CognitoAuth to AuthToken --------- Co-authored-by: Harsh <[email protected]> Co-authored-by: Abhash Kumar Singh <[email protected]> Co-authored-by: aws-amplify-ops <[email protected]> * add a high level readme file for AppSyncRealTimeClient module * add a high level readme file for WebSocketClient module * update push notification test scheme * revert changes made in push notification category --------- Co-authored-by: Harsh <[email protected]> Co-authored-by: Abhash Kumar Singh <[email protected]> Co-authored-by: aws-amplify-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the ability to pass
forceAliasCreation
flag during confirming sign up. Usage:General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.