Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Auth): Adding forceAliasCreation option during confirmSignUp #3382

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Nov 27, 2023

Description

Adding the ability to pass forceAliasCreation flag during confirming sign up. Usage:

      let pluginOptions = AWSAuthConfirmSignUpOptions(
            forceAliasCreation: true)
        let options = AuthConfirmSignUpRequest.Options(pluginOptions: pluginOptions)
        let result = try await self.plugin.confirmSignUp(
            for: "<username>",
            confirmationCode: "<confirmationCode>",
            options: options)

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner November 27, 2023 15:00
@harsh62 harsh62 requested a review from gpanshu November 27, 2023 15:01
sebaland
sebaland previously approved these changes Feb 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c7fec5) 68.10% compared to head (1edc681) 68.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3382      +/-   ##
==========================================
+ Coverage   68.10%   68.18%   +0.07%     
==========================================
  Files        1080     1080              
  Lines       36343    36347       +4     
==========================================
+ Hits        24753    24782      +29     
+ Misses      11590    11565      -25     
Flag Coverage Δ
API_plugin_unit_test 67.50% <ø> (ø)
AWSPluginsCore 64.14% <ø> (ø)
Amplify 48.10% <ø> (ø)
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.02% <100.00%> (-0.02%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.90% <ø> (+0.40%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.51% <ø> (ø)
unit_tests 68.18% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 merged commit 9615f5a into main Mar 18, 2024
78 checks passed
@harsh62 harsh62 deleted the forceAliasCreation-confirmSignUp-auth branch March 18, 2024 19:52
5d added a commit that referenced this pull request Mar 19, 2024
…RLSession (#3527)

* feat(datastore): replace appSync realtime client with URLSession

* Add timeout for appsync realtime request

* adding unit test cases

* move websocket components to core

* added more interfaces for unit test

* add unit test cases for websocket client

* fix broken integration test cases

* change appsync client state to a subject

* Add resettable for appsync and websocket clients

* add integration test cases for appsync client

* Add subscription actor

* fix subscription life cycle issue

* add integration test cases for datastore with large number of models

* add integration test case for max subscription reached

* fix auth error handling for AppSyncRealTimeRequest errors

* add doc comments for WebSocketClient and AppSyncRealTimeClient

* add integration test case for retry on maxSubscriptionReached

* move sendRequest to appSyncRealTimeClient

* Add more doc comments

* bind tasks cancellables to connection life cycle

* update websocket spi name

* resolve comments

* fix(Logging): Updating the required reason API usage (#3570)

* chore: release 2.27.3 [skip ci]

* chore: finalize release 2.27.3 [skip ci]

* feat(Auth): Adding forceAliasCreation option during confirmSignUp (#3382)

* feat(Auth): Adding forceAliasCreation option during confirmSignUp

* update pinpoint unit tests

* Revert "update pinpoint unit tests"

This reverts commit 0f804d8.

* rename CognitoAuth to AuthToken

---------

Co-authored-by: Harsh <[email protected]>
Co-authored-by: Abhash Kumar Singh <[email protected]>
Co-authored-by: aws-amplify-ops <[email protected]>
lawmicha pushed a commit that referenced this pull request Mar 20, 2024
) (#3577)

* feat(Auth): Adding forceAliasCreation option during confirmSignUp

* update pinpoint unit tests

* Revert "update pinpoint unit tests"

This reverts commit 0f804d8.

Co-authored-by: Harsh <[email protected]>
5d added a commit that referenced this pull request Mar 22, 2024
…RLSession (#3575)

* feat(API): implement AppSyncRealTimeClient and WebSocketClient with URLSession (#3527)

* feat(datastore): replace appSync realtime client with URLSession

* Add timeout for appsync realtime request

* adding unit test cases

* move websocket components to core

* added more interfaces for unit test

* add unit test cases for websocket client

* fix broken integration test cases

* change appsync client state to a subject

* Add resettable for appsync and websocket clients

* add integration test cases for appsync client

* Add subscription actor

* fix subscription life cycle issue

* add integration test cases for datastore with large number of models

* add integration test case for max subscription reached

* fix auth error handling for AppSyncRealTimeRequest errors

* add doc comments for WebSocketClient and AppSyncRealTimeClient

* add integration test case for retry on maxSubscriptionReached

* move sendRequest to appSyncRealTimeClient

* Add more doc comments

* bind tasks cancellables to connection life cycle

* update websocket spi name

* resolve comments

* fix(Logging): Updating the required reason API usage (#3570)

* chore: release 2.27.3 [skip ci]

* chore: finalize release 2.27.3 [skip ci]

* feat(Auth): Adding forceAliasCreation option during confirmSignUp (#3382)

* feat(Auth): Adding forceAliasCreation option during confirmSignUp

* update pinpoint unit tests

* Revert "update pinpoint unit tests"

This reverts commit 0f804d8.

* rename CognitoAuth to AuthToken

---------

Co-authored-by: Harsh <[email protected]>
Co-authored-by: Abhash Kumar Singh <[email protected]>
Co-authored-by: aws-amplify-ops <[email protected]>

* add a high level readme file for AppSyncRealTimeClient module

* add a high level readme file for WebSocketClient module

* update push notification test scheme

* revert changes made in push notification category

---------

Co-authored-by: Harsh <[email protected]>
Co-authored-by: Abhash Kumar Singh <[email protected]>
Co-authored-by: aws-amplify-ops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants