-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataStore): watchOS subscription disabled configuration value #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Inactive
lawmicha
had a problem deploying
to
IntegrationTest
December 20, 2023 15:33 — with
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
==========================================
+ Coverage 67.93% 67.95% +0.01%
==========================================
Files 1086 1086
Lines 36294 36294
==========================================
+ Hits 24657 24662 +5
+ Misses 11637 11632 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
lawmicha
temporarily deployed
to
IntegrationTest
December 20, 2023 16:10 — with
GitHub Actions
Inactive
thisisabhash
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
subscriptionsDisabled
was incorrectly settingdisableSubscriptions
to return false. This wasn't caught since the developers tracking the original PR #3368 were using.custom(disableSubscriptions)
as communicated to them.subscriptionDisabled
is available as well and more targetted for customers that don't expect to change thedisableSubscriptions
return value.General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.