Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): update storage path validation rule #3579

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented Mar 21, 2024

Issue #

Description

  • Update StoragePath validation rule to not allow leading / in the path
  • Update related unit tests based on the new validation rule change

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner March 21, 2024 15:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.16%. Comparing base (8364412) to head (83861b3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/gen2_storage    #3579      +/-   ##
========================================================
- Coverage                 68.32%   68.16%   -0.16%     
========================================================
  Files                      1058     1073      +15     
  Lines                     35656    36256     +600     
========================================================
+ Hits                      24362    24714     +352     
- Misses                    11294    11542     +248     
Flag Coverage Δ
API_plugin_unit_test 67.50% <ø> (ø)
AWSPluginsCore 66.90% <ø> (ø)
Amplify 47.33% <ø> (ø)
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.02% <ø> (+0.02%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 82.37% <ø> (ø)
Geo_plugin_unit_test ?
Logging_plugin_unit_test 62.87% <ø> (?)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 76.44% <100.00%> (ø)
unit_tests 68.16% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantumcode phantumcode merged commit b8ec8d8 into feature/gen2_storage Mar 21, 2024
74 checks passed
@phantumcode phantumcode deleted the feat/gen2_storage_validation_update branch March 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants