Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): align storage validation exception message with Amplify Android #3612

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore(storage): align storage validation exception message with Amplify Android #3612

merged 1 commit into from
Apr 15, 2024

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented Apr 15, 2024 •
edited
Loading

Issue #

Aligning StoragePath validation exception message with Amplify Android.

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner April 15, 2024 14:26
@phantumcode phantumcode changed the title chore(storage): align storage validation exception message with Ampli… chore(storage): align storage validation exception message with Amplify Android Apr 15, 2024
@phantumcode phantumcode merged commit 8e2bfa7 into feature/gen2_storage Apr 15, 2024
74 checks passed
@phantumcode phantumcode deleted the phantum/update_storage_exception branch April 15, 2024 18:05
@phantumcode phantumcode mentioned this pull request Apr 15, 2024
Merged
9 tasks
lawmicha pushed a commit that referenced this pull request Apr 16, 2024
@phantumcode @lawmicha
chore(storage): align storage validation exception message with Ampli…
cff728d 
…fy Android (#3612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phantumcode @harsh62