Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update aws-sdk-swift to 1.0.69 #3948

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sebaland
Copy link
Member

Description

This PR includes the changes from #3942 to upgrade the aws-sdk-swift dependency to 1.0.69, which makes it possible to enable C++ interoperability mode (ref).

I'm also updating the Xcode and OS versions in our workflows, and skipping the usage of the build cache when the dependency cache is not found (this caused issues when updating dependencies)

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
    • Integration Tests (Except DataStore & API)
    • Integration Tests | API - All
    • Integration Tests | DataStore - All
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from a team as code owners January 10, 2025 22:14
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (b247482) to head (a8b61a9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3948      +/-   ##
==========================================
- Coverage   67.76%   67.74%   -0.02%     
==========================================
  Files        1125     1125              
  Lines       52126    52126              
==========================================
- Hits        35325    35315      -10     
- Misses      16801    16811      +10     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (ø)
AWSPluginsCore 70.36% <ø> (ø)
Amplify 47.89% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.70% <ø> (+<0.01%) ⬆️
DataStore_plugin_unit_test 83.28% <ø> (-0.13%) ⬇️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.11% <ø> (ø)
Predictions_plugin_unit_test 35.42% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.88% <ø> (ø)
unit_tests 67.74% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebaland sebaland deployed to IntegrationTest January 10, 2025 22:44 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants