Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IoT): Using a custom atomic dictionary for topic listeners #5415

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(IoT): Using a custom atomic dictionary for topic listeners #5415

merged 1 commit into from
Aug 1, 2024

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented Jul 31, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
Reverting previous changes to AWSSynchronizedMutableDictionary and instead creating a custom and internal AWSIoTAtomicDictionary that just uses NSLock to perform the operations.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland force-pushed the ruisebas/dictionary_crash branch from 5db072f to d99817b Compare July 31, 2024 23:11
@sebaland sebaland temporarily deployed to IntegrationTest July 31, 2024 23:12 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest July 31, 2024 23:12 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest July 31, 2024 23:12 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest July 31, 2024 23:12 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 1, 2024 14:57 — with GitHub Actions Inactive
@sebaland sebaland marked this pull request as ready for review August 1, 2024 15:27
@sebaland sebaland requested review from awsmobilesdk and a team as code owners August 1, 2024 15:27
@sebaland sebaland merged commit d2335a2 into main Aug 1, 2024
67 checks passed
@sebaland sebaland deleted the ruisebas/dictionary_crash branch August 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5d 5d 5d approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebaland @5d