Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pinpoint): Fixing error decoding AWSPinpointEndpointProfile when attributes are set. #5431

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

sebaland
Copy link
Member

Description of changes:

When the user sets user attributes to Pinpoint's AWSPinpointEndpointProfile, it's successfully encoded and stored in the Keychain. However, attempting to decode it back failed with an error.

Error unarchiving class `AWSPinpointEndpointProfile`: Error Domain=NSCocoaErrorDomain Code=4864 "value for key 'NS.objects' was of unexpected class 'NSMutableArray' (0x1ec41f220) [/Library/Developer/CoreSimulator/Volumes/iOS_21F79/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.5.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/CoreFoundation.framework].
Allowed classes are:
 {(
    "'NSDictionary' (0x1ec41edc0)
 )}

This was caused due to not setting the right classes on the AWSPinpointEndpointProfileUser decoding process.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners August 30, 2024 16:21
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:21 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest August 30, 2024 16:41 — with GitHub Actions Inactive
@sebaland sebaland merged commit f9f4a25 into main Sep 4, 2024
67 checks passed
@sebaland sebaland deleted the ruisebas/fix-endpoint-user branch September 4, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants