Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TranscribeStreaming): Adding support for missing languages. #5483

Merged
merged 3 commits into from
Dec 30, 2024
Merged

feat(TranscribeStreaming): Adding support for missing languages. #5483

merged 3 commits into from
Dec 30, 2024

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Dec 20, 2024 •
edited
Loading

Description of changes:
This PR adds support for the missing languages in Transcribe Streaming listed here

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested review from awsmobilesdk and a team as code owners December 20, 2024 22:03
ruisebas
ruisebas commented Dec 20, 2024
View reviewed changes
AWSTranscribeStreaming/AWSTranscribeStreamingModel.m
}];
}

+ (NSValueTransformer *)mediaEncodingJSONTransformer {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some weird reason the diff gets confused and thinks this method has been removed, when it's totally still in there 🤷‍♂️

@ruisebas ruisebas marked this pull request as draft December 20, 2024 22:18
@ruisebas ruisebas marked this pull request as ready for review December 23, 2024 17:53
harsh62
harsh62 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruisebas ruisebas merged commit cd17613 into main Dec 30, 2024
67 checks passed
@ruisebas ruisebas deleted the ruisebas/transcribestreaming-languages branch December 30, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisabhash thisisabhash thisisabhash approved these changes

@harsh62 harsh62 harsh62 approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruisebas @harsh62 @thisisabhash