Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample codes for Auth.deleteUserAttributes in JS #3413

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

hkjpotato
Copy link
Contributor

Issue #, if available:

Description of changes:
Follow existing updateUserAttributes, add samples code for the upcoming AuthdeleteUserAttributes api in JS.

Related PR: aws-amplify/amplify-js#7342

API review has been done internally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hkjpotato hkjpotato requested a review from a team July 21, 2021 19:14
@hkjpotato hkjpotato requested review from a team as code owners July 21, 2021 19:14
@hkjpotato hkjpotato changed the title Kj/js auth delete user attributes add sample codes for Auth.deleteUserAttributes in JS Jul 21, 2021
@hkjpotato hkjpotato requested a review from aws-eddy July 22, 2021 19:22
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hkjpotato 🌮

We can merge this after releasing the JS change

@hkjpotato
Copy link
Contributor Author

LGTM! Thanks @hkjpotato 🌮

We can merge this after releasing the JS change

@elorzafe Thank you @elorzafe !!!

@aws-eddy aws-eddy requested a review from renebrandel July 23, 2021 16:16
@aws-eddy
Copy link
Contributor

@hkjpotato thanks for the docs update. LGTM 🌮

@hkjpotato hkjpotato merged commit 7a41009 into main Jul 23, 2021
@hkjpotato hkjpotato deleted the kj/js-auth-delete-user-attributes branch July 23, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants