add rpdk.log to initially generated default .gitignore #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/682214d782e20ee197ae2711bde06602d12a5d20/python/rpdk/java/data/java.gitignore#L20 https://github.com/aws-cloudformation/cloudformation-cli-go-plugin/blob/7b9fc8d8848ad2666298fbcf077c0f2d4d264a2b/python/rpdk/go/data/go.gitignore#L6
PatMyron
requested review from
wbingli,
nina-ctrlv,
rjlohan,
miparnisari,
johnttompkins,
anshikg and
ammokhov
anshikg
approved these changes
Aug 10, 2020
rjlohan
previously requested changes
Aug 10, 2020
miparnisari
approved these changes
Aug 10, 2020
rjlohan
approved these changes
Aug 10, 2020
PatMyron
added a commit
to aws-cloudformation/cloudformation-cli-go-plugin
that referenced
this pull request
Aug 26, 2020
PatMyron
added a commit
to aws-cloudformation/cloudformation-cli-java-plugin
that referenced
this pull request
Aug 26, 2020
PatMyron
added a commit
to aws-cloudformation/cloudformation-cli-go-plugin
that referenced
this pull request
Aug 26, 2020
PatMyron
added a commit
to aws-cloudformation/cloudformation-cli-java-plugin
that referenced
this pull request
Aug 26, 2020
angpalm
added a commit
to Nextdoor/cloudformation-cli-go-plugin
that referenced
this pull request
Sep 11, 2020
* Add AWS Account ID, region, partition, system tags, next token in the request to handler (aws-cloudformation#157) * add request context * update test * wildcard .gitignore pattern in case rpdk.log rotates (aws-cloudformation#158) aws-cloudformation/cloudformation-cli-python-plugin#110 (comment) * Fix log throttle (aws-cloudformation#159) * only create the log group once * update test * remove extra line * Update "generated file" hint to follow go convention. (aws-cloudformation#161) Go has a documented[1] convention identifying "generated" files: > To convey to humans and machine tools that code is generated, > generated source should have a line that matches the following > regular expression (in Go syntax): > ^// Code generated .* DO NOT EDIT\.$ [1]: https://golang.org/pkg/cmd/go/internal/generate/ * Bump up python plugin version to 2.0.1 (aws-cloudformation#166) Co-authored-by: Brian Terry <[email protected]> Co-authored-by: Pat Myron <[email protected]> Co-authored-by: Niko Eckerskorn <[email protected]> Co-authored-by: omkhegde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java and Go plugins already have this in
.gitignoresam-tests/.gitignorePRs:Java
Python
Go