[Misc]: changing all walkdirs to use the same cmp operator #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
akshayrane,
dannyvassallo,
razcloud,
setttings,
Brianwithay21,
wkexiang,
brianlaoaws,
reza-aws,
rpdutt and
minhphuong98
minhphuong98
approved these changes
Feb 2, 2024
dannyvassallo
approved these changes
Feb 2, 2024
akshayrane
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
While working on #448 the team noticed some discrepancies in the tests on different OS platforms when validating output. This was due to differences in the way different OS's default sort their files. To fix this we are now making all our walkers use the same sort as we are already using for our rule files.
Changes in this PR update all the walking of directories, and create a single function that returns an IntoIterator for the walkdir crate.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license