-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github-action): Implement cfn-guard as a Github Action in TS #510
feat(github-action): Implement cfn-guard as a Github Action in TS #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asside from some nits, this looks good to me.
I think we should add some lints. Personally I think we should enforce ;
at the end of statements. I personally find it much easier to read with them.
Added semi rule with autoformatting. |
Hey folks, I think this is awesome (looking very much forward to using it)! One thing that would be interesting to consider (that's kinda independent of this PR), is if this should (also?) exist under https://github.com/aws-actions. |
@benbridts Hey! Great suggestion. During design we'd considered having the action live in it's own repo outside of the guard monorepo but ultimately decided on nesting it here. It's something to talk about though so while we have it here at least for now to do some testing, I'm bringing this back to the team to discuss. Thank you! |
37cc2ad
into
aws-cloudformation:action-develop
Issue #, if available: N/A
Description of changes:
Utilizes the cfn-guard TS lib inside of a github action.
File changes primarily exist under
action/src
,action/__tests/
,.github/workflows
, andaction.yml
on the root.If you want to read the changes like a compiler, start at
action/src/main.ts
THIS DOES NOT INCLUDE FURTHER ATTRIBUTION AND DOES NOT INCLUDE README UPDATES
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license