Add permissions to tagging schema #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Permissions field in tagging schema to specify permissions needed for tags. Add unit test for permissions field.
ammokhov
reviewed
May 25, 2023
Comment on lines
169
to
172
| } else if (key.equals(ResourceTagging.TAG_PERMISSIONS)) { | ||
| HashSet<String> tagPermissions = new HashSet<>(); | ||
| ((List<?>) value).forEach(p -> tagPermissions.add(p.toString())); | ||
| taggingValue.setTagPermissions(tagPermissions); |
There was a problem hiding this comment.
do we need to make it HashSet? Why dont we use list, then you dont really need to convert it
There was a problem hiding this comment.
I follow the type definition in Handler.java as Set<String> and I think the handler permissions is also set as an Hashset, but I am not sure whether it is a must for tagging permissions. I can change it to list.
WaelA
approved these changes
May 30, 2023
AidenAtSea
approved these changes
May 30, 2023
ammokhov
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add permissions field in tagging schema to specify permissions needed for tags.
Add unit test for permissions field.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.