Add dockerfile linter in CI #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningziwen
force-pushed
the
linter
branch
3 times, most recently
from
4a4e888 to
219c9b0
Compare
Signed-off-by: Ziwen Ning <[email protected]>
thaotruong-aws
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dockerfile linter in CI
Had to add two steps for neuron and neuronx.
Hadolint-action supports multiple Dockerfiles by pattern but seems not arbitrary two names.
Using pattern "Dockerfile.*" will include cve allowlists and they cannot be excluded.
Only fail on error for now. Can refactor to remove warning and info later.