Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Fix concurrent git update breaking changelog generation #1477

Closed
1 of 2 tasks
heitorlessa opened this issue Aug 25, 2022 · 1 comment
Closed
1 of 2 tasks
Assignees
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

We need to ensure GH Actions git client can pull and rebase before pushing any changes to reduce the off chances a concurrent update prevents a push.

Why is this needed?

We auto-merge safe dependencies from dependabot. In rare incidents, this caused the release to fail as the Git tip was not up to date. For typical workflows this isn't a challenge, but for releases where it might have ~2m gap between checkout and push this can happen more often.

Which area does this relate to?

Governance

Solution

Solution differs from the usual git pull --rebase origin <BRANCH>, because git is in detached mode when workflows are trigger under release notes. We need a solution that solves both -- PR incoming.

Acknowledgment

@heitorlessa heitorlessa added the internal Maintenance changes label Aug 25, 2022
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Aug 25, 2022
@github-actions
Copy link
Contributor

This is now released under 1.28.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Aug 25, 2022
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

2 participants