Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): prevent concurrent git update in critical workflows #1478

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 25, 2022

Issue number: #1477

Summary

Changes

Please provide a summary of what's being changed

  • Optionally add a git remote if we're in Detached mode (during releases)
  • Re-enable changelog job in the Release workflow
  • Renamed publish.yml to on_release_notes.yml to better describe its intent
  • Used env to signal which branch should we pull from and push to to ease reusability for our TS, .NET, and Java friends should they need it in the future

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner August 25, 2022 07:31
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team August 25, 2022 07:31
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Aug 25, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 25, 2022
@github-actions github-actions bot added the internal Maintenance changes label Aug 25, 2022
@heitorlessa heitorlessa merged commit 2cf223d into aws-powertools:develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants