Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sns to batch processing #1291

Closed
wants to merge 1 commit into from

Conversation

sergiors
Copy link

@sergiors sergiors commented Jul 12, 2022

Summary

Hi, this is my first PR here. I don't know very well the project under the hood, but I use it in my stack.
I would like to some help to finish the tests

Changes

Added support to SNS on Batch Processing

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 12, 2022

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #1291 (411fbd1) into develop (5bed1fe) will decrease coverage by 0.09%.
The diff coverage is 70.58%.

@@             Coverage Diff             @@
##           develop    #1291      +/-   ##
===========================================
- Coverage    99.88%   99.79%   -0.10%     
===========================================
  Files          119      119              
  Lines         5423     5435      +12     
  Branches       618      620       +2     
===========================================
+ Hits          5417     5424       +7     
- Misses           2        7       +5     
  Partials         4        4              
Impacted Files Coverage Δ
aws_lambda_powertools/utilities/batch/base.py 95.55% <37.50%> (-3.66%) ⬇️
aws_lambda_powertools/logging/formatter.py 100.00% <100.00%> (ø)
aws_lambda_powertools/logging/logger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06965bb...411fbd1. Read the comment docs.

@heitorlessa
Copy link
Contributor

Opa @sergiors, thank you for helping us improve this project. Could you open a feature request before we discuss implementation? We're currently paused for new features until the end of the month.

That being said, Amazon SNS doesn't support partial failure reporting like SQS, DynamoDB Streams, or Kinesis Data Streams. We can discuss more in a feature request on what experience you'd like to have as the behavior will differ from others - e.g., what should we do with messages that fail processing in a SNS batch?

Thanks!

@heitorlessa heitorlessa added need-issue PRs that are missing related issues do-not-merge labels Jul 12, 2022
@sergiors
Copy link
Author

That being said, Amazon SNS doesn't support partial failure reporting like SQS, DynamoDB Streams, or Kinesis Data Streams. We can discuss more in a feature request on what experience you'd like to have as the behavior will differ from others - e.g., what should we do with messages that fail processing in a SNS batch?

I didn't know that. I will study more and maybe I can bring a new solution to this.
I will close this PR and request the features like you said. For know, thanks for your feedback.

@sergiors sergiors closed this Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge need-issue PRs that are missing related issues size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants