Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

TypeScript refresh #694

Closed
wants to merge 12 commits into from
Closed

Conversation

josh-demuth
Copy link

Refresh of some of the TypeScript workshop content. This is from an AWS TFC project. This includes:

  • updating the lib/cdk-workshop-stack.ts code to match how the latest version of the cdk init command imports the main cdk package and uses Constructs instead of App types.
  • also includes notices for issues we've seen participants run into when running the workshop (i.e. a blurb about package-lock.json and how to fix issues that may come up).
  • updated screenshots for Lambda test instructions due to recent console changes.
  • included the Dynamo removal policy from the beginning due to this [cli] Change sets that consist only of removalPolicy changes cannot be executed  aws/aws-cdk#11521 which won't remove the table with the current instructions.
  • updated a few git commands since existing ones did not catch any new files that needed to be tracked by git.
  • other minor updates to instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 License.

@indrora
Copy link
Contributor

indrora commented Aug 1, 2023

Well then.

After merging in a lot of small community contributions, much of the content here is in conflict. This is also a very large change overall, with lots of fixes elsewhere.

Could you please rebase this change against the current main branch and verify your changes?

@indrora indrora added pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version. pr/work-in-progress This PR is a draft and needs further work. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. pr/needs-review This PR needs a review from a Member. labels Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Aug 4, 2023
@github-actions github-actions bot closed this Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version. pr/needs-review This PR needs a review from a Member. pr/work-in-progress This PR is a draft and needs further work. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants