feat: Main branch validation #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamkhidir
reviewed
Jan 8, 2025
| @@ -84,7 +84,7 @@ def test_add_rss(client: AppSyncClient): | |||
|
|
|||
| ready = False | |||
| retries = 0 | |||
| while not ready and retries < 10: | |||
| while not ready and retries < 20: | |||
There was a problem hiding this comment.
nit: Why are we increasing the retries here?
There was a problem hiding this comment.
In some case the test was slow/flaky. I increased the wait time to see if it improves it.
maryamkhidir
reviewed
Jan 8, 2025
| run: | | ||
| executionId=$(aws codepipeline start-pipeline-execution --name ${{ secrets.PIPELINE_NAME }} --region ${{ secrets.PIPELINE_AWS_REGION }} --query "pipelineExecutionId" --output text) | ||
| sleep 60 | ||
| while true; do |
There was a problem hiding this comment.
Do we need to add a timeout here for indefinite runs or this is already handled by aws code pipeline?
There was a problem hiding this comment.
There is a default one of 6h. We could set one later if needed.
maryamkhidir
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Trigger validation on changes on the main branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.