Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[240]: chat history language through prompt order #247

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

kylelee24
Copy link
Contributor

Issue #, if available:
#240

Description of changes:
When using application in English, chat history shows as Spanish as described in issue #240.

Changing prompt rule ordering used to determine chat history title. Moved - Title must be in the same language as the conversation. to end.

Before fix:
image

After fix:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@statefb
Copy link
Contributor

statefb commented Apr 16, 2024

@kylelee24 Thank you for your contribution! Do you have any statistical evidence to show that the prompt is better than previous one?

@kylelee24
Copy link
Contributor Author

kylelee24 commented Apr 16, 2024

@kylelee24 Thank you for your contribution! Do you have any statistical evidence to show that the prompt is better than previous one?

I only have the before/after fix screenshots I posted in the PR. You can see in the second screenshot the 3 same questions asked returned chat history titles in English. Testing seems to return consistent results.

@statefb
Copy link
Contributor

statefb commented Apr 16, 2024

Thank you. I'll merge this, but since there is not enough evidence, I would like to leave the issue #240 open.

@statefb statefb merged commit 69f50cb into aws-samples:main Apr 16, 2024
6 checks passed
@kylelee24 kylelee24 deleted the fix/chat-history-language branch April 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants