Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistral models support #253

Merged
merged 29 commits into from
Apr 26, 2024
Merged

Conversation

hustshawn
Copy link
Contributor

@hustshawn hustshawn commented Apr 17, 2024

Issue #, if available:

Description of changes:

Added Mistral models end-to-end support. Currently Mistral 7b and Mistral 8x7b are supported. Example effect in UI like below.

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@statefb statefb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments in the codes, please add or modify:

  • Make it configrable in cdk.json.
    • like enableMistral, default is False
      • if False, the model options should not be showing on the chat screen.
  • Add documents on README.md
    • Add some explanation in Others section.
    • Please emphasize that this sample is not fully support mistral.
      • for example, prompt examples are based on claude.

Thank you in adnvance!

backend/app/usecases/chat.py Outdated Show resolved Hide resolved
backend/app/usecases/chat.py Outdated Show resolved Hide resolved
backend/app/usecases/chat.py Outdated Show resolved Hide resolved
backend/app/usecases/chat.py Show resolved Hide resolved
backend/app/websocket.py Show resolved Hide resolved
backend/tests/test_usecases/test_bedrock_extra_model.py Outdated Show resolved Hide resolved
@hustshawn
Copy link
Contributor Author

In addition to the comments in the codes, please add or modify:

  • Make it configrable in cdk.json.

    • like enableMistral, default is False

      • if False, the model options should not be showing on the chat screen.
  • Add documents on README.md

    • Add some explanation in Others section.

    • Please emphasize that this sample is not fully support mistral.

      • for example, prompt examples are based on claude.

Thank you in adnvance!

This has been addressed with latest commit.

@hustshawn
Copy link
Contributor Author

hustshawn commented Apr 23, 2024

Late night here, I will add mistral-large models support tomorrow.
added support for Mistral large with latest commit.

README.md Show resolved Hide resolved
@hustshawn
Copy link
Contributor Author

@statefb as all comments are resolved, would you please merge it?

backend/tests/test_usecases/test_chat.py Outdated Show resolved Hide resolved
backend/tests/test_usecases/test_chat.py Outdated Show resolved Hide resolved
cdk/cdk.json Outdated Show resolved Hide resolved
cdk/lib/bedrock-chat-stack.ts Outdated Show resolved Hide resolved
cdk/lib/constructs/frontend.ts Outdated Show resolved Hide resolved
cdk/bin/bedrock-chat.ts Outdated Show resolved Hide resolved
cdk/lib/constructs/frontend.ts Outdated Show resolved Hide resolved
cdk/lib/constructs/frontend.ts Outdated Show resolved Hide resolved
backend/app/repositories/models/conversation.py Outdated Show resolved Hide resolved
backend/app/config.py Show resolved Hide resolved
backend/app/bedrock.py Outdated Show resolved Hide resolved
cdk/test/cdk.test.ts Show resolved Hide resolved
backend/app/bedrock.py Outdated Show resolved Hide resolved
@statefb statefb merged commit 588c099 into aws-samples:main Apr 26, 2024
6 checks passed
@statefb
Copy link
Contributor

statefb commented Apr 26, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants