Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve eslint findings #54

Closed
flamingquaks opened this issue May 16, 2024 · 0 comments · Fixed by #56
Closed

fix: resolve eslint findings #54

flamingquaks opened this issue May 16, 2024 · 0 comments · Fixed by #56
Assignees
@flamingquaks

Comments

@flamingquaks
Copy link
Contributor

No description provided.

@flamingquaks flamingquaks self-assigned this May 16, 2024
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
916062e
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
6509bc1
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
080b64c
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
style: prettified code base
b0946b0 
Prettified code post-initial ESLint

re #54
@flamingquaks flamingquaks mentioned this issue May 21, 2024
Merged
@flamingquaks flamingquaks linked a pull request May 21, 2024 that will close this issue
#54 fix:resolve eslint findings #56
Merged
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
0196b82
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
2aeea19
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
9b52f11
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
3137bd9
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
1241d92
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
a7ee2ba
flamingquaks added a commit that referenced this issue May 21, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
46efe00
flamingquaks added a commit that referenced this issue May 22, 2024
@flamingquaks
fix: fixed eslint and typescript functionality to successfuly clear i…
8e9ea93 
…ssues

re: #54
flamingquaks added a commit that referenced this issue May 22, 2024
@flamingquaks
WIP: fix: resolve eslint findings #54
9d35cb7
flamingquaks added a commit that referenced this issue May 23, 2024
@flamingquaks
refactor(cli): changed while loops from constant true to dynamic bool…
59d5a36 
…eans

CLI had while(true) loops which have a higher risk of infinate loop. Replaced with variables.

re: #54
flamingquaks added a commit that referenced this issue May 23, 2024
@flamingquaks
style: resolve eslint findings
8a62c84 
* Create eslint.yml to automate eslint findings in GitHub Actions

* style(eslint): resolved style related findings for eslint

* refactor(cli): changed while loops from constant true to dynamic booleans

CLI had while(true) loops which have a higher risk of infinate loop. Replaced with variables.

re: #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flamingquaks flamingquaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#54 fix:resolve eslint findings aws-samples/generative-ai-newsletter-app
1 participant
@flamingquaks