fix: AppSync Functions fail to compile on Windows OS #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to shift building of resolver assets to the build process from the synth process
Added better handling for UI configurations being completely undefined
…oid windows glob issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to run
npm run buildon a Windows OS, the compiler would often freeze or error. This was related to the way that windows handles wildcard filepaths.To allow the AppSync functions to be compiled in accordance with AWS Best Practices (See DynamoDB Resolvers Documentation, the esbuild execution is now defined in
lib/api/functions/bundle.tswhich is executed bynpm run build:appsync(npm run buildincludes a call tonpm run build:appsync). This will call the bundle logic fromts-node.By shifting the logic into a file, I'm able to remain OS agnostic and more directly locate the specific files that need compilation.
PR also contains a fix for the UI construct that was failing to parse the configuration file properly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.