Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support model name for iPhone 15 series #37

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. support model name for iPhone 15 series

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Sep 25, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane September 25, 2023 05:41
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (459f25b) 95.17% compared to head (c2d612c) 95.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          34       34           
  Lines        1761     1763    +2     
=======================================
+ Hits         1676     1678    +2     
  Misses         85       85           
Files Changed Coverage Δ
...Clickstream/AutoRecord/AutoRecordEventClient.swift 98.08% <100.00%> (-0.03%) ⬇️
...eam/Dependency/Clickstream/System/SystemInfo.swift 99.14% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit ea9885b into main Sep 25, 2023
@zxkane zxkane deleted the support_iphone15 branch September 25, 2023 08:34
zhu-xiaowei added a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants