Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] use go modules #2493

Closed
wants to merge 2 commits into from
Closed

[wip] use go modules #2493

wants to merge 2 commits into from

Conversation

sharanyad
Copy link
Contributor

@sharanyad sharanyad commented Jun 24, 2020

Summary

moving away from godep for dependency management and using go modules.

Implementation details

from agent/

go mod init
go mod tidy
rm -rf vendor
go mod vendor

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sharanyad
Copy link
Contributor Author

build failure in windows:

+go build -installsuffix cgo -a -ldflags ' -s' -o out/amazon-ecs-agent ./agent/
# github.com/aws/amazon-ecs-agent/agent/vendor/github.com/docker/docker/pkg/system
agent/vendor/github.com/docker/docker/pkg/system/filesys_windows.go:113:24: cannot use uintptr(unsafe.Pointer(&sd[0])) (type uintptr) as type *"github.com/aws/amazon-ecs-agent/agent/vendor/golang.org/x/sys/windows".SECURITY_DESCRIPTOR in assignment
Makefile:44: recipe for target 'xplatform-build' failed
make: *** [xplatform-build] Error 2
The command "make xplatform-build" exited with 2.

@sharanyad
Copy link
Contributor Author

golang/go#34610 - x/sys API changes broke windows

needs update to docker/docker package to consume the latest x/sys/windows

@mythri-garaga
Copy link
Contributor

WIP #2576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants