Fixed some race conditions in task engine tests #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this originated from copying test code from a unit test that already had this bug because of the race condition. The deleted line of code used to result in race condition and it would trigger the task engine to do additional work after the test would complete leading to test failures. Should fix aws#669
…tainerReturnsUnretriableError test
aaithal
requested review from
nmeyerhans,
samuelkarp,
petderek and
richardpen
jwerak
pushed a commit
to appuri/amazon-ecs-agent
that referenced
this pull request
Jun 8, 2017
* Fix event state race condition in task engine unit tests. I think this originated from copying test code from a unit test that already had this bug because of the race condition. The deleted line of code used to result in race condition and it would trigger the task engine to do additional work after the test would complete leading to test failures. Should fix aws#669 * Vendor gomock with support for MinTimes * Add documentation for using MinTimes in TestTaskTransitionWhenStopContainerReturnsUnretriableError test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix event state race condition in task engine unit tests
Implementation details
I think this originated from copying test code from a unit test
that already had this bug because of the race condition. The deleted
line of code used to result in race condition and it would trigger
the task engine to do additional work after the test would complete
leading to test failures.
Should fix #669
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: No, but modified test code does.
Description for the changelog
None
Licensing
This contribution is under the terms of the Apache 2.0 License: Yes